Skip large rows #224
Merged
Skip large rows #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e870628 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
PR Overview
This pull request adds a JSON size check for rows during replication to prevent errors caused by oversized documents while syncing.
- Update changeset metadata to indicate patch versions and describe the skipping of large rows.
- Add a check in PersistedBatch.ts to bypass rows whose JSON size exceeds MAX_ROW_SIZE and log an error.
- Export MAX_ROW_SIZE from MongoBucketBatch.ts and update MongoDB dependency versions in pnpm-lock.yaml.
Reviewed Changes
| File | Description |
|---|---|
| .changeset/fast-flowers-scream.md | Updated changeset metadata to reflect the new behavior and patched package versions |
| modules/module-mongodb-storage/src/storage/implementation/PersistedBatch.ts | Introduces a JSON size check to skip large rows, preventing replication failures |
| modules/module-mongodb-storage/src/storage/implementation/MongoBucketBatch.ts | Exports the MAX_ROW_SIZE constant for external usage |
| pnpm-lock.yaml | Updates mongodb dependency versions to support the new changes |
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
modules/module-mongodb-storage/src/storage/implementation/PersistedBatch.ts
Show resolved
Hide resolved
stevensJourney
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replication could fail with this error:
We already have a maximum size check for 15MB for storing "current_data". However, that checks BSON size, while the actual synced documents use JSON, which could be larger. So there is a small range of sizes that would pass the size check, but then fail when persisting, breaking the entire replication process. This adds a check for the JSON size, skipping these rows.